From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@linux-foundation.org>,
Jack Steiner <steiner@sgi.com>,
linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, <linuxppc-dev@ozlabs.org>
Subject: [PATCH 7/8] powerpc irq: update powerpc for new irq_desc
Date: Mon, 12 Jan 2009 14:05:26 -0800 [thread overview]
Message-ID: <20090112220520.566552000@polaris-admin.engr.sgi.com> (raw)
In-Reply-To: <20090112220519.566749000@polaris-admin.engr.sgi.com>
[-- Attachment #1: irq:update-powerpc-to-new-irq_desc --]
[-- Type: text/plain, Size: 2236 bytes --]
Impact: cleanup, update to new cpumask API
Irq_desc.affinity and irq_desc.pending_mask are now cpumask_var_t's
so access to them should be using the new cpumask API.
Signed-off-by: Mike Travis <travis@sgi.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: <linuxppc-dev@ozlabs.org>
---
arch/powerpc/kernel/irq.c | 2 +-
arch/powerpc/platforms/pseries/xics.c | 5 +++--
arch/powerpc/sysdev/mpic.c | 3 ++-
3 files changed, 6 insertions(+), 4 deletions(-)
--- linux-2.6-for-ingo.orig/arch/powerpc/kernel/irq.c
+++ linux-2.6-for-ingo/arch/powerpc/kernel/irq.c
@@ -231,7 +231,7 @@ void fixup_irqs(cpumask_t map)
if (irq_desc[irq].status & IRQ_PER_CPU)
continue;
- cpus_and(mask, irq_desc[irq].affinity, map);
+ cpumask_and(&mask, irq_desc[irq].affinity, &map);
if (any_online_cpu(mask) == NR_CPUS) {
printk("Breaking affinity for irq %i\n", irq);
mask = map;
--- linux-2.6-for-ingo.orig/arch/powerpc/platforms/pseries/xics.c
+++ linux-2.6-for-ingo/arch/powerpc/platforms/pseries/xics.c
@@ -153,9 +153,10 @@ static int get_irq_server(unsigned int v
{
int server;
/* For the moment only implement delivery to all cpus or one cpu */
- cpumask_t cpumask = irq_desc[virq].affinity;
+ cpumask_t cpumask;
cpumask_t tmp = CPU_MASK_NONE;
+ cpumask_copy(&cpumask, irq_desc[virq].affinity);
if (!distribute_irqs)
return default_server;
@@ -869,7 +870,7 @@ void xics_migrate_irqs_away(void)
virq, cpu);
/* Reset affinity to all cpus */
- irq_desc[virq].affinity = CPU_MASK_ALL;
+ cpumask_setall(irq_desc[virq].affinity);
desc->chip->set_affinity(virq, cpu_all_mask);
unlock:
spin_unlock_irqrestore(&desc->lock, flags);
--- linux-2.6-for-ingo.orig/arch/powerpc/sysdev/mpic.c
+++ linux-2.6-for-ingo/arch/powerpc/sysdev/mpic.c
@@ -566,9 +566,10 @@ static void __init mpic_scan_ht_pics(str
#ifdef CONFIG_SMP
static int irq_choose_cpu(unsigned int virt_irq)
{
- cpumask_t mask = irq_desc[virt_irq].affinity;
+ cpumask_t mask;
int cpuid;
+ cpumask_copy(&mask, irq_desc[virt_irq].affinity);
if (cpus_equal(mask, CPU_MASK_ALL)) {
static int irq_rover;
static DEFINE_SPINLOCK(irq_rover_lock);
--
next prev parent reply other threads:[~2009-01-12 22:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 22:05 [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's Mike Travis
2009-01-12 22:05 ` [PATCH 1/8] alpha irq: update alpha for new irq_desc Mike Travis
2009-01-12 22:05 ` [PATCH 2/8] arm irq: update arm " Mike Travis
2009-01-12 22:05 ` [PATCH 3/8] blackfin irq: update blackfin " Mike Travis
2009-01-12 22:05 ` [PATCH 4/8] ia64 irq: update ia64 " Mike Travis
2009-01-12 22:05 ` [PATCH 5/8] mips irq: update mips " Mike Travis
2009-01-12 22:05 ` [PATCH 6/8] parisc irq: update parisc " Mike Travis
2009-01-13 6:04 ` Kyle McMartin
2009-01-12 22:05 ` Mike Travis [this message]
2009-01-12 22:05 ` [PATCH 8/8] sparc irq: update sparc " Mike Travis
2009-01-12 22:07 ` [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's Mike Frysinger
2009-01-13 1:21 ` Mike Travis
2009-01-13 1:25 ` Mike Frysinger
2009-01-12 22:20 ` Ingo Molnar
2009-01-12 22:21 ` Ingo Molnar
2009-01-12 22:31 ` Mike Travis
2009-01-12 22:52 ` Ingo Molnar
2009-01-13 0:15 ` Mike Travis
2009-01-14 11:14 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112220520.566552000@polaris-admin.engr.sgi.com \
--to=travis@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®