From: Ingo Molnar <mingo@elte.hu>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Robert Richter <robert.richter@amd.com>,
Steven Rostedt <rostedt@redhat.com>,
linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ring_buffer: NUMA aware page allocations
Date: Tue, 13 Jan 2009 02:29:37 +0100 [thread overview]
Message-ID: <20090113012937.GB15492@elte.hu> (raw)
In-Reply-To: <496B97F1.70200@cosmosbay.com>
* Eric Dumazet <dada1@cosmosbay.com> wrote:
> Hi Robert & Steven
>
> While browsing oprofile code in current tree, I discovered
> drivers/oprofile/cpu_buffer.c was using new ring_buffer code.
>
> Apparently we lost in the conversion NUMA allocations, unless
> I am mistaken, since rb_allocate_pages() uses plain
> __get_free_page(GFP_KERNEL) calls to allocate pages.
>
> All "buffer_page" structs are allocated with kzalloc_node(),
> but not the pages themselves.
>
> Thank you
>
> [PATCH] ring_buffer: NUMA aware page allocations
>
> rb_allocate_pages() & ring_buffer_resize() should use alloc_pages_node()
> instead of __get_free_page() to allocate pages.
nice improvement!
Ingo
prev parent reply other threads:[~2009-01-13 1:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 19:20 Eric Dumazet
2009-01-13 1:29 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113012937.GB15492@elte.hu \
--to=mingo@elte.hu \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.richter@amd.com \
--cc=rostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®