From: Sam Ravnborg <sam@ravnborg.org>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
harvey.harrison@gmail.com, gorcunov@gmail.com, roque@di.fc.ul.pt,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH -tip] in6.h: extern's make no sense in userspace
Date: Tue, 13 Jan 2009 08:15:13 +0100 [thread overview]
Message-ID: <20090113071513.GB20036@uranus.ravnborg.org> (raw)
In-Reply-To: <1231829859.3212.19.camel@jaswinder.satnam>
On Tue, Jan 13, 2009 at 12:27:39PM +0530, Jaswinder Singh Rajput wrote:
> Impact: fix 2 make headers_check warnings:
>
> usr/include/linux/in6.h:47: extern's make no sense in userspace
> usr/include/linux/in6.h:49: extern's make no sense in userspace
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> include/linux/in6.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/in6.h b/include/linux/in6.h
> index bc49204..718bf21 100644
> --- a/include/linux/in6.h
> +++ b/include/linux/in6.h
> @@ -44,11 +44,11 @@ struct in6_addr
> * NOTE: Be aware the IN6ADDR_* constants and in6addr_* externals are defined
> * in network byte order, not in host byte order as are the IPv4 equivalents
> */
> +#ifdef __KERNEL__
> extern const struct in6_addr in6addr_any;
> #define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } }
> extern const struct in6_addr in6addr_loopback;
> #define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }
> -#ifdef __KERNEL__
It looks wrong what IN6ADDR_ANY_INIT should be a kernel only symbol.
At least google had some hits on that symbol.
netdev people should know....
Sam
next prev parent reply other threads:[~2009-01-13 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 6:57 Jaswinder Singh Rajput
2009-01-13 7:15 ` Sam Ravnborg [this message]
2009-01-13 7:20 ` Jaswinder Singh Rajput
2009-01-13 7:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113071513.GB20036@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=gorcunov@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=roque@di.fc.ul.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®