mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: LKML <linux-kernel@vger.kernel.org>,
	linux-ia64 <linux-ia64@vger.kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>, Kyle McMartin <kyle@mcmartin.ca>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tony Luck <tony.luck@intel.com>
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: [mmotm][PATCH] fix ia64 build error
Date: Thu, 15 Jan 2009 20:05:08 +0900 (JST)	[thread overview]
Message-ID: <20090115200315.EBE3.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)


Applied after: linux-next.patch
==
Subject: [PATCH] remove duplicate EXPORT_SYMBOL()
Impact: fix build error

In past, ia64_ksyms.c had EXPORT_SYMBOL(copy_page) in wrong place.

old code was

	#include <asm/uaccess.h>
	EXPORT_SYMBOL(__copy_user);
	EXPORT_SYMBOL(__do_clear_user);
	EXPORT_SYMBOL(__strlen_user);
	EXPORT_SYMBOL(__strncpy_from_user);
	EXPORT_SYMBOL(__strnlen_user);
	EXPORT_SYMBOL(copy_page);

(but actually, copy_page is declared in asm/page.h)

And recently, commit bdc2619ab95d45d434c16d5c216bc6243761f6fb insert
EXPORT_SYMBOL(copy_page) into correct place.

then, duplicate EXPORT_SYMBOL create following build error.

arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__kcrctab_copy_page'
arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__kcrctab_copy_page' was here
arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__kstrtab_copy_page'
arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__kstrtab_copy_page' was here
arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__ksymtab_copy_page'
arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__ksymtab_copy_page' was here


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tony Luck <tony.luck@intel.com>
---
 arch/ia64/kernel/ia64_ksyms.c |    1 -
 1 file changed, 1 deletion(-)

Index: b/arch/ia64/kernel/ia64_ksyms.c
===================================================================
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -40,7 +40,6 @@ EXPORT_SYMBOL(__do_clear_user);
 EXPORT_SYMBOL(__strlen_user);
 EXPORT_SYMBOL(__strncpy_from_user);
 EXPORT_SYMBOL(__strnlen_user);
-EXPORT_SYMBOL(copy_page);
 
 /* from arch/ia64/lib */
 extern void __divsi3(void);



             reply	other threads:[~2009-01-15 11:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15 11:05 KOSAKI Motohiro [this message]
2009-01-15 17:35 ` Andrew Morton
2009-01-15 17:52   ` Luck, Tony
2009-01-16  1:49   ` linux-next: build problem with nfs tree (Was: Re: [mmotm][PATCH] fix ia64 build error) Stephen Rothwell
2009-01-16  1:59     ` Andrew Morton
2009-01-16  2:49       ` Stephen Rothwell
2009-01-16  3:41         ` KOSAKI Motohiro
2009-01-16  4:34         ` Stephen Rothwell
2009-01-16 22:15           ` Andrew Morton
2009-01-16 22:40             ` Stephen Rothwell
2009-01-16 22:49               ` Stephen Rothwell
2009-01-16 22:51               ` Andrew Morton
2009-01-17  4:43       ` David Howells
2009-01-17  5:00         ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090115200315.EBE3.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=kyle@mcmartin.ca \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®