Re: [GIT PULL -tip] x86: fix 22 make headers_check warnings

[Ingo Molnar <mingo@elte.hu>]

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> [Ingo Molnar - Sat, Jan 17, 2009 at 05:41:08PM +0100]
> | 
> | * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> | 
> | > Hello Ingo,
> | > 
> | > The following changes since commit 206e00df0967f6e91d792df7f1d4ff352eb42f8f:
> | >   Ingo Molnar (1):
> | >         Merge branch 'x86/urgent'
> | > 
> | > are available in the git repository at:
> | > 
> | >   git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tiptop.git master
> | > 
> | > Jaswinder Singh Rajput (8):
> | >       x86: boot.h fix make headers_check
> | >       x86: e820.h fix make headers_check
> | >       x86: kvm.h fix make headers_check
> | >       x86: mce.h fix make headers_check
> | >       x86: mtrr.h fix make headers_check
> | >       x86: ptrace-abi.h fix make headers_check
> | >       x86: sigcontext.h fix make headers_check
> | >       x86: swab.h fix make headers_check
> | > 
> | >  arch/x86/include/asm/boot.h       |    2 ++
> | >  arch/x86/include/asm/e820.h       |   11 ++++++++---
> | >  arch/x86/include/asm/kvm.h        |    2 +-
> | >  arch/x86/include/asm/mce.h        |    5 +----
> | >  arch/x86/include/asm/mtrr.h       |    1 +
> | >  arch/x86/include/asm/ptrace-abi.h |    5 ++++-
> | >  arch/x86/include/asm/sigcontext.h |    2 +-
> | >  arch/x86/include/asm/swab.h       |   21 +++++++++++++++++++--
> | >  8 files changed, 37 insertions(+), 12 deletions(-)
> | 
> | Pulled into tip/core/header-fixes and started testing them, thanks 
> | Jaswinder!
> | 
> | 	Ingo
> | 
> 
> I thought some of them I've already fixed, no?

ah, indeed - tip/x86/setup-lzma is currently not in tip/master (due to a 
breakage that is being investigated), that's why i missed it.

So i took out the boot.h change from core/headers-fixes and your fix will 
take precedence.

btw:

> Cyrill Gorcunov wrote:
> > Small series of headers cleanup, easy to bisect.
> > make headers_check still complains about vars
> > being found in comments but this is just a false
> > alarm. Please review.
> 
> Applied patch 1 to tip:x86/setup-lzma, and patches 2, 4 and 5 to
> tip:x86/header-fixes.

those x86/header-fixes bits from you are in core/headers-fixes now:

 dbca1df: x86: headers cleanup - setup.h
 a7c4e68: x86: headers cleanup - sigcontext32.h
 4440270: x86: headers cleanup - prctl.h

So i think we are all sorted, agreed?

	Ingo