From: Ingo Molnar <mingo@elte.hu>
To: Mandeep Singh Baines <msb@google.com>
Cc: linux-kernel@vger.kernel.org, hannes@cmpxchg.org,
rientjes@google.com, mbligh@google.com, thockin@google.com
Subject: Re: [PATCH] softlockup: fix potential race in hung_task when resetting timeout
Date: Sun, 18 Jan 2009 19:22:36 +0100 [thread overview]
Message-ID: <20090118182236.GB24570@elte.hu> (raw)
In-Reply-To: <20090117183148.GA20173@google.com>
* Mandeep Singh Baines <msb@google.com> wrote:
> Patch against tip/core/softlockup.
>
> ---
>
> A potential race exists if sysctl_hung_task_timeout_secs is reset to 0
> while inside check_hung_uniterruptible_tasks(). If check_task() is
> entered, a comparison with 0 will result in a false hung_task being
> detected.
>
> If sysctl_hung_task_panic is set, the system will panic.
>
> Signed-off-by: Mandeep Singh Baines <msb@google.com>
> ---
> kernel/hung_task.c | 24 ++++++++++++++++--------
> 1 files changed, 16 insertions(+), 8 deletions(-)
Applied to tip/core/softlockup, thanks Mandeep!
Ingo
prev parent reply other threads:[~2009-01-18 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 17:09 [PATCH] softlockup: fix to allow compiling with !DETECT_HUNG_TASK Mandeep Singh Baines
2009-01-16 17:18 ` Ingo Molnar
2009-01-17 18:31 ` [PATCH] softlockup: fix potential race in hung_task when resetting timeout Mandeep Singh Baines
2009-01-18 18:22 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090118182236.GB24570@elte.hu \
--to=mingo@elte.hu \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=msb@google.com \
--cc=rientjes@google.com \
--cc=thockin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®