From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Pavel Machek <pavel@suse.cz>,
Carsten Schlote <c.schlote@konzeptpark.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATA] Add ide-disk led-trigger to ATA subsystem
Date: Sun, 18 Jan 2009 18:29:55 +0000 [thread overview]
Message-ID: <20090118182955.5e994064@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <49734FC6.9070500@garzik.org>
On Sun, 18 Jan 2009 10:50:30 -0500
Jeff Garzik <jeff@garzik.org> wrote:
> Pavel Machek wrote:
> > On Sat 2009-01-10 16:08:27, Carsten Schlote wrote:
> >> void ata_sff_exec_command(struct ata_port *ap, const struct
> >> ata_taskfile *tf)
> >> {
> >> + ledtrig_ide_activity();
> >> +
> >> DPRINTK("ata%u: cmd 0x%X\n", ap->print_id, tf->command);
> >>
> >> iowrite8(tf->command, ap->ioaddr.command_addr);
> >>
> >
> > Is there a more generic place so that we won't have to modify all the
> > libata drivers?
>
>
> One would think you could do this at the block layer...
ata_sff_exec_command is also on a timing critical path so the wrong place
to be touching other stuff. It's mid command issue.
prev parent reply other threads:[~2009-01-18 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 15:08 Carsten Schlote
2009-01-14 8:25 ` Andrew Morton
2009-01-18 8:11 ` Pavel Machek
2009-01-18 15:50 ` Jeff Garzik
2009-01-18 18:29 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090118182955.5e994064@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=c.schlote@konzeptpark.de \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®