From: Alexey Dobriyan <adobriyan@gmail.com>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: staging driver (epl)
Date: Tue, 20 Jan 2009 00:03:15 +0300 [thread overview]
Message-ID: <20090119210315.GA3805@x200.localdomain> (raw)
Greg, can I ssh to your box to do
git rm -rf drivers/staging/epl
sed -i -e '/epl/d' drivers/staging/Kconfig
sed -i -e '/CONFIG_EPL/d' drivers/staging/Makefile
git commit -a -m 'staging: remove epl driver'
?
This driver doesn't meet even _the_ basic requirements.
It's _full_ of hungarian notation (iRet).
It's full of typedefs.
It's full of HAL (tEplApiInstance etc).
Filenames (!) are in CamelCase.
It creates sockets from kernel for something.
It tries to interact with devfs.
It may come as surprise but you also committed real Win32 code:
drivers/staging/epl/EplTimeruWin32.c
drivers/staging/epl/ShbIpc-Win32.c
Amazing, isn't it?
Do you accept _any_ code? Exactly zero entry barrier?
next reply other threads:[~2009-01-19 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 21:03 Alexey Dobriyan [this message]
2009-01-19 23:59 ` Greg KH
2009-01-20 6:04 ` Alexey Dobriyan
2009-01-20 6:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119210315.GA3805@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®