mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Howells <dhowells@redhat.com>
Cc: James Morris <jmorris@namei.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Hannes Eder" <hannes@hanneseder.net>
Subject: Re: [PATCH] creds: suppress warning in get_cred
Date: Tue, 20 Jan 2009 01:52:51 +1100	[thread overview]
Message-ID: <20090120015251.47ea14ff.sfr@canb.auug.org.au> (raw)
In-Reply-To: <11956.1232368171@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Hi David,

On Mon, 19 Jan 2009 12:29:31 +0000 David Howells <dhowells@redhat.com> wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > +	return get_new_cred((struct cred *)(uintptr_t)cred);
> 
> That should probably be 'unsigned long' within the kernel.  This is also a
> compiler bug, but I think we can live with this fix.

We do have uintptr_t inside the kernel (it is typedeffed to unsigned
long) but I used it explicitly because its type is defined to be large
enough to store any pointer.

However, I have also verified that using a newer compiler (4.3.2 in my
case) makes the warning go away as Hannes Eder pointed out when
mentioning his earlier patch.

So, your choice.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-01-19 14:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-19 10:10 Stephen Rothwell
2009-01-19 11:03 ` Hannes Eder
2009-01-19 14:37   ` Stephen Rothwell
2009-01-19 12:29 ` David Howells
2009-01-19 14:52   ` Stephen Rothwell [this message]
2009-01-19 14:59     ` Hannes Eder
2009-01-19 20:19   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090120015251.47ea14ff.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dhowells@redhat.com \
    --cc=hannes@hanneseder.net \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®