From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: linux-media@vger.kernel.org, video4linux-list@redhat.com,
Sam Ravnborg <sam@ravnborg.org>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Confusion in usr/include/linux/videodev.h
Date: Tue, 20 Jan 2009 23:50:48 -0200 [thread overview]
Message-ID: <20090120235048.4f7200f9@caramujo.chehab.org> (raw)
In-Reply-To: <1232502038.3123.61.camel@localhost.localdomain>
On Wed, 21 Jan 2009 07:10:38 +0530
Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> usr/include/linux/videodev.h is giving 2 warnings in 'make headers_check':
> usr/include/linux/videodev.h:19: leaks CONFIG_VIDEO to userspace where it is not valid
> usr/include/linux/videodev.h:314: leaks CONFIG_VIDEO to userspace where it is not valid
>
> Whole file is covered with #if defined(CONFIG_VIDEO_V4L1_COMPAT) || !defined (__KERNEL__)
>
> It means this file is only valid for kernel mode if CONFIG_VIDEO_V4L1_COMPAT is defined but in user mode it is always valid.
>
> Can we choose some better alternative Or can we use this file as:
>
> #ifdef CONFIG_VIDEO_V4L1_COMPAT
> #include <linux/videodev.h>
> #endif
This is somewhat like what we have on audio devices (where there are OSS and ALSA API's).
V4L1 is the old deprecated userspace API for video devices. It is still
required by some userspace applications. So, on userspace, it should be
included. Also, this allows that one userspace app to be compatible with both
V4L2 API (the current one) and the legacy V4L1 one.
It should be noticed that are still a few drivers using the legacy API yet to
be converted.
Cheers,
Mauro
next prev parent reply other threads:[~2009-01-21 1:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 1:40 Jaswinder Singh Rajput
2009-01-21 1:50 ` Mauro Carvalho Chehab [this message]
2009-01-21 4:44 ` Jaswinder Singh Rajput
2009-01-21 8:54 ` Trent Piepho
2009-01-21 8:59 ` Jaswinder Singh Rajput
2009-01-21 9:09 ` Arnd Bergmann
2009-01-21 9:51 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120235048.4f7200f9@caramujo.chehab.org \
--to=mchehab@infradead.org \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®