From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756410AbZAVBTE (ORCPT ); Wed, 21 Jan 2009 20:19:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756056AbZAVBSs (ORCPT ); Wed, 21 Jan 2009 20:18:48 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:43872 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756019AbZAVBSr (ORCPT ); Wed, 21 Jan 2009 20:18:47 -0500 Date: Wed, 21 Jan 2009 17:18:49 -0800 (PST) Message-Id: <20090121.171849.220592075.davem@davemloft.net> To: yinghai@kernel.org Cc: mpm@selenic.com, mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: sparc64 build breakage... From: David Miller In-Reply-To: <20090121.171553.142827920.davem@davemloft.net> References: <20090121.171553.142827920.davem@davemloft.net> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha id n0M1JIwM017628 From: David Miller Date: Wed, 21 Jan 2009 17:15:53 -0800 (PST) > > This change: > > commit d7e51e66899f95dabc89b4d4c6674a6e50fa37fc > Author: Yinghai Lu > Date: Wed Jan 7 15:03:13 2009 -0800 > > sparseirq: make some func to be used with genirq > > breaks the sparc64 build: ... > arch/sparc/kernel/irq_64.c: In function ‘show_interrupts’: > arch/sparc/kernel/irq_64.c:188: error: ‘struct kernel_stat’ has no member named ‘irqs’ > make[1]: *** [arch/sparc/kernel/irq_64.o] Error 1 > > This should fix it: > > sparc64: Fix build by using kstat_irqs_cpu(). Actually this isn't enough, next failure: arch/sparc/kernel/time_64.c: In function ‘timer_interrupt’: arch/sparc/kernel/time_64.c:732: error: implicit declaration of function ‘kstat_incr_irqs_this_cpu’ make[1]: *** [arch/sparc/kernel/time_64.o] Error 1 There seems to be a disconnect in linux/kernel_stat.h about providing the same set of interfaces whether GENERIC_IRQS is set or not. kstat_incr_irqs_this_cpu is one example. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I