mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: lockdep and debug objects together are broken?
Date: Wed, 21 Jan 2009 08:19:50 +0100	[thread overview]
Message-ID: <20090121071950.GM24891@wotan.suse.de> (raw)
In-Reply-To: <19f34abd0901201311t2425056dia6182812f7270297@mail.gmail.com>

On Tue, Jan 20, 2009 at 10:11:47PM +0100, Vegard Nossum wrote:
> On Tue, Jan 20, 2009 at 9:55 AM, Nick Piggin <npiggin@suse.de> wrote:
> > Hi,
> >
> > I've had a problem frustrating my testing because lockdep was silently turning
> > itself off... I patched out the code to disable lockdep after the first error,
> > and it started showing up weird errors. kernel/fork.c:990 seemed to be the
> > first to trigger (hard irqs disabled) from a call_usermodehelper call. Later,
> > migration thread was reported to try to unlock rq->lock although it was
> > holding no locks. Then init was reported to return to userspace without
> > releasing an objectdebug hash lock.
> >
> > All that went away and everything seemed to work properly with debug objects
> > configured out.
> >
> > I didn't get too far in trying to debug the problem. But it should be easy
> > enough to reproduce (if not, I can post traces or test patches).
> 
> I just built a kernel with lockdep and debugobjects enabled, and
> everything seemed fine. I think you should post your kernel version,
> config, and the lockdep patch (if needed -- it didn't seem to turn
> itself off here).

Are you sure? Ie. sysrq+D a still works properly? In that case, you
wouldn't need the lockdep patch because it just prevents the feature from being
switched off.

I'll have to dig a bit further, then. The annoying thing is that
lockdep turns itself off at the drop of a hat (and this particular
problem seems to happen without any backtraces), so it invalidates
all your lockdep testing if you don't realise it has turned itself
off.

Is there a way to re-arm lockdep? That would be neat.


  reply	other threads:[~2009-01-21  7:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20  8:55 Nick Piggin
2009-01-20 21:11 ` Vegard Nossum
2009-01-21  7:19   ` Nick Piggin [this message]
2009-01-21 11:42     ` Ingo Molnar
2009-01-21 11:50       ` Peter Zijlstra
2009-01-21 11:54         ` Ingo Molnar
2009-01-21 11:54       ` Nick Piggin
2009-01-21 11:57         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090121071950.GM24891@wotan.suse.de \
    --to=npiggin@suse.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®