mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Niels de Vos <niels.devos@wincor-nixdorf.com>
Cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
	Michael Bramer <michael@debsupport.de>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] drivers/serial/8250_pci.c (add support for '8-port RS-232 MIC-3620 from advantech'
Date: Wed, 21 Jan 2009 12:32:15 +0000	[thread overview]
Message-ID: <20090121123215.1b3acc4d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4976DF6F.2010509@wincor-nixdorf.com>

> >>  static struct pci_device_id serial_pci_tbl[] = {
> >> +       {       PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620,
> >> +               0x3620, PCI_ANY_ID, 0, 0,
> 
> Why not use PCI_VENDOR_ID_ADVANTECH as PCI_SUBVENDOR_ID too?

The Advantech vendor id is not 0x3620. This confused me as well which is
why I asked for an lspci. Advantech has stuck the device id in the
subvendor bits and '1' in the subdevice (so it should be 1 not
PCI_ANY_ID).

Alan

  reply	other threads:[~2009-01-21 12:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18 13:53 Michael Bramer
2009-01-18 14:14 ` Alan Cox
2009-01-19 11:45   ` Michael Bramer
2009-01-19 14:51 ` Andrey Panin
2009-01-19 23:51   ` Michael Bramer
2009-01-20 15:12     ` Andrey Panin
2009-01-21  7:52       ` Michael Bramer
2009-01-21  8:18         ` Paulius Zaleckas
2009-01-21  8:40           ` Niels de Vos
2009-01-21 12:32             ` Alan Cox [this message]
2009-01-21 23:42               ` Michael Bramer
2009-01-22  8:21                 ` Tosoni
2009-01-22  9:03                   ` Niels de Vos
2009-01-22 11:00                     ` Michael Bramer
2009-01-22 11:47                       ` Paulius Zaleckas
2009-01-22 16:44                         ` Michael Bramer
2009-01-21 23:40           ` Michael Bramer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090121123215.1b3acc4d@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=michael@debsupport.de \
    --cc=niels.devos@wincor-nixdorf.com \
    --cc=paulius.zaleckas@teltonika.lt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®