From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 1/5] trace: do not disable wake up tracer on output of trace
Date: Thu, 22 Jan 2009 13:03:37 +0100 [thread overview]
Message-ID: <20090122120337.GB22594@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0901220658050.22776@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Well actually, I don't see the output causing any issues. That's another
> point. Should we work on adding all this complex code for something that
> might not every cause an issues? I added it because it did cause an
> issue with the irqs off traces, although I'm not sure that is true any
> more either. I just added it to the wakeup tracer just to be consistent.
>
> With the new trace_off switch that disables the ring buffer, and the
> stopping of the swap buffers with the switch off, I do not think that
> this code is even necessary anymore.
>
> I think I'll rip out the code from irqsoff and see if it is still an
> issue there. If not, I think we can get rid of it.
agreed - if the output itself does not disturb max-latency tracing in
practice then i'm all for ripping it out.
Ingo
next prev parent reply other threads:[~2009-01-22 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 23:53 [PATCH 0/5] ftrace: updates for tip Steven Rostedt
2009-01-21 23:53 ` [PATCH 1/5] trace: do not disable wake up tracer on output of trace Steven Rostedt
2009-01-22 8:41 ` Ingo Molnar
2009-01-22 9:29 ` Ingo Molnar
2009-01-22 12:02 ` Steven Rostedt
2009-01-22 12:03 ` Ingo Molnar [this message]
2009-01-21 23:53 ` [PATCH 2/5] ring-buffer: do not swap if recording is disabled Steven Rostedt
2009-01-21 23:53 ` [PATCH 3/5] trace: separate out rt tasks from wakeup tracer Steven Rostedt
2009-01-21 23:53 ` [PATCH 4/5] wakeup-tracer: show scheduling data in output Steven Rostedt
2009-01-21 23:53 ` [PATCH 5/5] ring-buffer: reset timestamps when ring buffer is reset Steven Rostedt
2009-01-22 9:32 ` [PATCH 0/5] ftrace: updates for tip Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122120337.GB22594@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®