From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] icside: use struct ide_port_info also for PCB version 5
Date: Sat, 24 Jan 2009 14:50:51 +0000 [thread overview]
Message-ID: <20090124145051.GA26833@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200901241514.23036.bzolnier@gmail.com>
On Sat, Jan 24, 2009 at 03:14:22PM +0100, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] icside: use struct ide_port_info also for PCB version 5
>
> This fixes hwif->channel and drive->dn assignments.
I really don't care about this driver anymore - people should
be using the PATA version instead.
Nevertheless, this patch looks broken.
> @@ -534,7 +538,7 @@ icside_register_v6(struct icside_state *
^^^^^^^^^^^^^^^^^^ v6 function
> d.dma_ops = NULL;
> }
>
> - ret = ide_host_register(host, NULL, hws);
> + ret = ide_host_register(host, &icside_v5_port_info, hws);
^^^^^^^^^^^^^^^^^^^^^ v5 info
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2009-01-24 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 14:14 Bartlomiej Zolnierkiewicz
2009-01-24 14:50 ` Russell King [this message]
2009-01-24 15:44 ` Bartlomiej Zolnierkiewicz
2009-01-24 15:46 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090124145051.GA26833@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®