mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Turner <pjt@google.com>, linux-kernel@vger.kernel.org
Subject: Re: Migration of kernel interfaces to seq_files breaks pread() consumers
Date: Sun, 25 Jan 2009 15:08:18 +0300	[thread overview]
Message-ID: <20090125120818.GA4454@x200.localdomain> (raw)
In-Reply-To: <20090124181924.d633523c.akpm@linux-foundation.org>

On Sat, Jan 24, 2009 at 06:19:24PM -0800, Andrew Morton wrote:
> On Fri, 16 Jan 2009 23:51:35 -0800 (PST) Paul Turner <pjt@google.com> wrote:
> 
> > 
> > (Specifically) Several interfaces under /proc have been migrated to use 
> > seq_files.  This was previously observed to be a problem with VMware's 
> > reading of /proc/uptime.  We're now running into the same problem on  
> > /proc/<pid>/stat; we have many consumers performing preads on this 
> > interface which break under new kernels.
> > 
> > Reverting these migrations presents other problems and doesn't scale with 
> > everyones' pet dependencies over an abi that's been
> > broken :(
> 
> We changed userspace-visible behaviour and broke real applications. 
> This is a serious matter.  So serious in fact that your report has
> languished without reply for a week.
> 
> Reverting those changes until we have a suitable reimplementation which
> doesn't bust userspace is 100% justifiable.
> 
> In which kernel versions is this regression present?
> 
> What would a revert look like?  Big and ugly or small and simple?  Do
> the original commits (which were they?) still revert OK?

This is bug http://bugzilla.kernel.org/show_bug.cgi?id=11856
Some of us think what to do here.

Original patch not revertable as is.

  parent reply	other threads:[~2009-01-25 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-17  7:51 Paul Turner
2009-01-25  2:19 ` Andrew Morton
2009-01-25  3:40   ` Paul Turner
2009-01-25 12:08   ` Alexey Dobriyan [this message]
2009-01-27 21:47     ` Eric W. Biederman
2009-01-27 21:48       ` [PATCH 1/2] seq_file: Move traverse so it can be used from seq_read Eric W. Biederman
2009-01-27 21:49         ` [PATCH 2/2] seq_file: Properly cope with pread Eric W. Biederman
2009-01-30  1:26       ` Migration of kernel interfaces to seq_files breaks pread() consumers Paul Turner
2009-01-30  3:01         ` Eric W. Biederman
2009-01-30  6:09           ` Paul Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090125120818.GA4454@x200.localdomain \
    --to=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®