mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86: Fix setion mismatch warning.
Date: Mon, 26 Jan 2009 14:28:49 +0100	[thread overview]
Message-ID: <20090126132849.GA13567@elte.hu> (raw)
In-Reply-To: <b9df5fa10901231146k89cd1adoee590b6743bb349f@mail.gmail.com>


* Rakib Mullick <rakib.mullick@gmail.com> wrote:

> Impact: Fix section mismatch warning.
> 
> Here function vmi_activate calls a init function activate_vmi , which
> causes the following section mismatch warnings. This patch fixes it.
> 
>   LD      arch/x86/kernel/built-in.o
> WARNING: arch/x86/kernel/built-in.o(.text+0x13ba9): Section mismatch
> in reference from the function vmi_activate() to the function
> .init.text:vmi_time_init()
> The function vmi_activate() references
> the function __init vmi_time_init().
> This is often because vmi_activate lacks a __init
> annotation or the annotation of vmi_time_init is wrong.
> 
> WARNING: arch/x86/kernel/built-in.o(.text+0x13bd1): Section mismatch
> in reference from the function vmi_activate() to the function
> .devinit.text:vmi_time_bsp_init()
> The function vmi_activate() references
> the function __devinit vmi_time_bsp_init().
> This is often because vmi_activate lacks a __devinit
> annotation or the annotation of vmi_time_bsp_init is wrong.
> 
> WARNING: arch/x86/kernel/built-in.o(.text+0x13bdb): Section mismatch
> in reference from the function vmi_activate() to the function
> .devinit.text:vmi_time_ap_init()
> The function vmi_activate() references
> the function __devinit vmi_time_ap_init().
> This is often because vmi_activate lacks a __devinit
> annotation or the annotation of vmi_time_ap_init is wrong.
> 
> 
> Thanks.
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

applied to tip/x86/urgent, thanks Rakib.

Note, the patch was corrupted here:

> +void __init vmi_activate(void)
>  {
>  	unsigned long flags;
> --

that's too short - context diffs have 3 closing lines. I fixed this up 
manually.

I also fixed the typo in the subject line.

Thanks,

	Ingo

      reply	other threads:[~2009-01-26 13:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-23 19:46 Rakib Mullick
2009-01-26 13:28 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090126132849.GA13567@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rakib.mullick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®