Re: 2.6.29rc1 brakes usb

[Oliver Neukum <oliver@neukum.org>]

Am Tuesday 27 January 2009 20:55:20 schrieb Folkert van Heusden:
> On Mon, Jan 26, 2009 at 08:11:19PM +0100, Oliver Neukum wrote:
> > > Since version 2.6.29rc1 querying cleware USb devices no longer works.
> > > 2.6.28 works fine. 2.6.29-rc2 also no longer works.
> > 
> > What kind of device is this? What happens if you try to use the device?
> > Isn't it detected, do you get an error?
> 
> It is a powerswitch that can be toggled via USB. Cleware also has
> sensors (temperature, humidity, etc.) that all can be handled via a
> commandline utility I wrote.
> It has been a while but if i remember correctly the failing ioctl is for
> determing the serial number of the device. That is required to talk to
> the right device. http://www.vanheusden.com/clewarecontrol/

There's a known bug in hiddev. Please test the included patch.

	Regards
		Oliver

---

--- linux-2.6/drivers/hid/usbhid/hiddev.c.alt	2009-01-26 20:03:10.000000000 +0100
+++ linux-2.6/drivers/hid/usbhid/hiddev.c	2009-01-26 20:03:17.000000000 +0100
@@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *fi
 
 	case HIDIOCGSTRING:
 		mutex_lock(&hiddev->existancelock);
-		if (!hiddev->exist)
+		if (hiddev->exist)
 			r = hiddev_ioctl_string(hiddev, cmd, user_arg);
 		else
 			r = -ENODEV;