mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
	Carsten Emde <carsten.emde@osadl.org>
Subject: [patch-rt 2/4] ftrace: fix erroneous histogram stop WARN_ON() messages
Date: Wed, 28 Jan 2009 21:29:12 -0000	[thread overview]
Message-ID: <20090128212709.228268535@linutronix.de> (raw)
In-Reply-To: <20090128211912.300823284@linutronix.de>

[-- Attachment #1: fix-erroneous-histogram-stop-warn-on-messages.patch --]
[-- Type: text/plain, Size: 967 bytes --]

IRQs are temporarily disabled during histogram calculation in
cycles_2_ns(). This causes a nested irqs_off histogram processing
which emittes an erroneous WARN_ON() message and also confuses the
histogramm output.

Change local_irq to raw_local_irq in cycles_2_ns to prevent irqs_off
histogram processing.

Tested-by: Carsten Emde <C.Emde@osadl.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 include/asm-x86/timer.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.26/include/asm-x86/timer.h
===================================================================
--- linux-2.6.26.orig/include/asm-x86/timer.h
+++ linux-2.6.26/include/asm-x86/timer.h
@@ -53,9 +53,9 @@ static inline notrace unsigned long long
 	unsigned long long ns;
 	unsigned long flags;
 
-	local_irq_save(flags);
+	raw_local_irq_save(flags);
 	ns = __cycles_2_ns(cyc);
-	local_irq_restore(flags);
+	raw_local_irq_restore(flags);
 
 	return ns;
 }

-- 


  parent reply	other threads:[~2009-01-28 21:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 21:28 [patch-rt 0/4] Bugfixes for 2.6.26-rt Thomas Gleixner
2009-01-28 21:29 ` [patch-rt 1/4] ftrace: fix swapped nibbles in tracer raw hex output Thomas Gleixner
2009-01-28 21:29 ` Thomas Gleixner [this message]
2009-01-28 21:29 ` [patch-rt 3/4] ftrace: display real preempt_count in ftracer Thomas Gleixner
2009-01-28 21:29 ` [patch-rt 4/4] sched: mark SCHED_HRTICK broken Thomas Gleixner
2009-01-29  9:58   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090128212709.228268535@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=carsten.emde@osadl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome