From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
jeff@garzik.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmi: Fix build breakage
Date: Wed, 28 Jan 2009 23:24:59 +0100 [thread overview]
Message-ID: <200901282325.00215.rjw@sisk.pl> (raw)
In-Reply-To: <1233122840-24142-1-git-send-email-galak@kernel.crashing.org>
On Wednesday 28 January 2009, Kumar Gala wrote:
> The following commit introduced:
>
> commit d7b1956fed33d30c4815e848fd7a143722916868
> Author: Rafael J. Wysocki <rjw@sisk.pl>
> Date: Mon Jan 19 20:55:50 2009 +0100
>
> DMI: Introduce dmi_first_match to make the interface more flexible
>
> compile errors like the following when !CONFIG_DMI
>
> drivers/ata/sata_sil.c: In function 'sil_broken_system_poweroff':
> drivers/ata/sata_sil.c:713: error: implicit declaration of function 'dmi_first_match'
> drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast
>
> We just need a dummy version of dmi_first_match() to fix this all up.
Well, my bad. Thanks for the fix!
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>
> This should supercede the driver specific patches I posted earlier.
>
> - k
>
> include/linux/dmi.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/dmi.h b/include/linux/dmi.h
> index aea2310..d741b9c 100644
> --- a/include/linux/dmi.h
> +++ b/include/linux/dmi.h
> @@ -65,6 +65,8 @@ static inline int dmi_walk(void (*decode)(const struct dmi_header *))
> { return -1; }
> static inline bool dmi_match(enum dmi_field f, const char *str)
> { return false; }
> +static inline const struct dmi_system_id *
> + dmi_first_match(const struct dmi_system_id *list) { return NULL; }
>
> #endif
>
Rafael
prev parent reply other threads:[~2009-01-28 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 6:07 Kumar Gala
2009-01-28 22:24 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901282325.00215.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=galak@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome