mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: horms@verge.net.au, randy.dunlap@oracle.com,
	linux-kernel@vger.kernel.org, miaox@cn.fujitsu.com,
	vgoyal@redhat.com
Subject: Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)
Date: Thu, 29 Jan 2009 16:15:05 -0500	[thread overview]
Message-ID: <20090129211505.GA10122@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20090129114859.ed963b2f.akpm@linux-foundation.org>

On Thu, Jan 29, 2009 at 11:48:59AM -0800, Andrew Morton wrote:
> On Thu, 29 Jan 2009 14:27:34 -0500
> Neil Horman <nhorman@tuxdriver.com> wrote:
> 
> > On Thu, Jan 29, 2009 at 10:01:57AM -0800, Andrew Morton wrote:
> > > On Thu, 29 Jan 2009 07:09:35 -0500 Neil Horman <nhorman@tuxdriver.com> wrote:
> > > 
> > > > > > So does that.
> > > > > > 
> > > > > > --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> > > > > > +++ a/kernel/printk.c
> > > > > > @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
> > > > > >  static int log_buf_len = __LOG_BUF_LEN;
> > > > > >  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
> > > > > >  
> > > > > > +#ifdef CONFIG_KEXEC
> > > > > >  void log_buf_kexec_setup(void)
> > > > > >  {
> > > > > >  	VMCOREINFO_SYMBOL(log_buf);
> > > > > >  	VMCOREINFO_SYMBOL(log_end);
> > > > > >  }
> > > > > > +#endif
> > > > > >  
> > > > > >  static int __init log_buf_len_setup(char *str)
> > > > > >  {
> > > > > > _
> > > > > 
> > > > > Weird, I thought I checked that just now. In any case this email
> > > > > was already in my inbox. In any case, I can now produce the problem,
> > > > > and this patch resolves it.
> > > > > 
> > > > 
> > > > Sorry, i didn't think to check on conditions when CONFIG_KEXEC wasn't set.  I
> > > > assumed we had a stub for all the VMCOREINFO defines.  Why don't we fix it in
> > > > that manner?  I mean we have serveral arch specific additions to vmcoreinfo, all
> > > > of which apparently must be ifdefd for this to work.  Why not just fix it in
> > > > conditional definition?
> > > 
> > > I didn't do that because then we'd have an empty function log_buf_kexec_setup()
> > > floating about in every vmlinux.
> > > 
> > > Hardly a big issue, but a bit regrettable.
> > > 
> > Won't the compiler just eliminate that symbol during final link, given that its
> > not an exported symbol?
> 
> I don't think it's that smart.
> 
> akpm:/home/akpm> cat t.c
> 
> void foo(void)
> {
> }
> 	
> main()
> {
> }
> akpm:/home/akpm> gcc -O2 t.c
> akpm:/home/akpm> nm a.out|grep foo
> 08048300 T foo
> 
> With -ffunction-sections or other fancy options, maybe.  And it'll be
> version-dependent.
> 
huh, how about that.  I always thought we stripped out empty functions.  Perhaps
that a later stage in most of the build processes I've used (a strip or
something later on perhaps).  Anywho, I stand corrected.  In light of this, its
probably best that we keep what we have, and just ifdef out the callers.

Thanks Andrew!
Neil

> 

  reply	other threads:[~2009-01-29 21:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200901281019.n0SAJ9C6013727@imap1.linux-foundation.org>
2009-01-28 16:56 ` Randy Dunlap
2009-01-29  0:30   ` Andrew Morton
2009-01-29  2:28     ` Simon Horman
2009-01-29 12:09       ` Neil Horman
2009-01-29 14:20         ` Vivek Goyal
2009-01-29 19:28           ` Neil Horman
2009-01-29 18:01         ` Andrew Morton
2009-01-29 19:27           ` Neil Horman
2009-01-29 19:48             ` Andrew Morton
2009-01-29 21:15               ` Neil Horman [this message]
2009-01-29  3:43 ` mmotm 2009-01-28-02-17 uploaded Valdis.Kletnieks
2009-01-29 17:44   ` Andrew Morton
2009-01-29  4:03 ` Valdis.Kletnieks
2009-01-29 16:25 ` mmotm 2009-01-28-02-17 uploaded - docking station issues Valdis.Kletnieks
2009-01-31  5:03   ` Andrew Morton
2009-01-31  8:40     ` Valdis.Kletnieks
2009-01-31  8:52       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090129211505.GA10122@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=akpm@linux-foundation.org \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    --cc=randy.dunlap@oracle.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®