From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755516AbZBAQmA (ORCPT ); Sun, 1 Feb 2009 11:42:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752618AbZBAQlu (ORCPT ); Sun, 1 Feb 2009 11:41:50 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:42423 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752297AbZBAQlt (ORCPT ); Sun, 1 Feb 2009 11:41:49 -0500 Date: Sun, 1 Feb 2009 11:41:30 -0500 From: Christoph Hellwig To: Eric Sandeen Cc: Boaz Harrosh , Geert Uytterhoeven , Arnd Bergmann , mfasheh@suse.com, joel.becker@oracle.com, linux-kernel@vger.kernel.org, hch@infradead.org, xfs-masters@oss.sgi.com, viro@zeniv.linux.org.uk, Ankit Jain , linux-fsdevel@vger.kernel.org, Andrew Morton , xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com Subject: Re: [xfs-masters] [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Message-ID: <20090201164130.GA32276@infradead.org> References: <20090130171423.f99c88d0.akpm@linux-foundation.org> <200901310248.42820.arnd@arndb.de> <49856FE6.8020601@panasas.com> <49857BEB.30404@panasas.com> <4985966D.8040402@panasas.com> <4985C1B0.8060905@sandeen.net> <4985CCFA.4070008@panasas.com> <4985CF66.6090409@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4985CF66.6090409@sandeen.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The structures have been defined exactly like that in XFS (and ocfs2) before, and there are similar cases in other ioctls handlers. If anyone feels like changing this in some way feel free to wade through the endless discussions about the pros and cons for it, but I think doing it in context of this patch is not helpful.