From: Mark Brown <broonie@sirena.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: sameo@openedhand.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mfd: Improve diagnostics for WM8350 ID register probe
Date: Mon, 2 Feb 2009 11:42:16 +0000 [thread overview]
Message-ID: <20090202114215.GA19282@sirena.org.uk> (raw)
In-Reply-To: <20090202110013.GA16510@sirena.org.uk>
On Mon, Feb 02, 2009 at 11:00:17AM +0000, Mark Brown wrote:
> On Fri, Jan 30, 2009 at 12:10:09PM -0800, Andrew Morton wrote:
> > Reading a bunch of bytes into a u16 looks a bit fishy from the endianness
> > point of view?
> Hrm, yeah. I'll send a patch for this. Shouldn't be an issue in
> practice since this is a primary PMIC and is unlikely to be used to
> power anything with the wrong endianness.
...or not, the code is already OK. The next block of code uses
be16_to_cpu() on all the values before they're actually used.
next prev parent reply other threads:[~2009-02-02 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 16:18 [PATCH 1/3] mfd: Mark WM835x USB_SLV_500MA bit as accessible Mark Brown
2009-01-23 16:18 ` [PATCH 2/3] mfd: Initialise WM8350 interrupts earlier Mark Brown
2009-01-23 16:18 ` [PATCH 3/3] mfd: Improve diagnostics for WM8350 ID register probe Mark Brown
2009-01-30 20:10 ` Andrew Morton
2009-02-02 11:00 ` Mark Brown
2009-02-02 11:42 ` Mark Brown [this message]
2009-02-06 13:57 ` [PATCH 1/3] mfd: Mark WM835x USB_SLV_500MA bit as accessible Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090202114215.GA19282@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®