From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
"kernel@avr32linux.org" <kernel@avr32linux.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hskinnemoen@atmel.com" <hskinnemoen@atmel.com>
Subject: Re: [PATCH] atmel-mci: fix initialization of dma slave data
Date: Mon, 2 Feb 2009 16:01:35 +0100 [thread overview]
Message-ID: <20090202160135.3b10233f@hcegtvedt> (raw)
In-Reply-To: <1233419203.5959.6.camel@dwillia2-linux.ch.intel.com>
On Sat, 31 Jan 2009 09:26:43 -0700
Dan Williams <dan.j.williams@intel.com> wrote:
> Subject: atmel-mci: fix initialization of dma slave data
>
> From: Dan Williams <dan.j.williams@intel.com>
>
> The conversion of atmel-mci to dma_request_channel missed the
> initialization of the channel dma_slave information. The filter_fn
> passed to dma_request_channel is responsible for initializing the
> channel's private data. This implementation has the additional
> benefit of enabling a generic client-channel data passing mechanism.
>
FWIW I ran this through an ALSA sound driver I'm working on for AVR32,
uses the DW DMA controller and this was exactly what I needed to pass
on the information about the slave. Seems to behave fine on my setup,
I'm working against the 2.6.29-rc3 tag.
> Reviewed-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
<snipp patch which adds a private pointer to struct dma_chan>
--
Best regards,
Hans-Christian Egtvedt
next prev parent reply other threads:[~2009-02-02 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 23:05 Dan Williams
2009-01-31 12:06 ` Atsushi Nemoto
2009-01-31 14:52 ` Atsushi Nemoto
2009-01-31 16:26 ` Dan Williams
2009-02-02 15:01 ` Hans-Christian Egtvedt [this message]
2009-02-02 16:04 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090202160135.3b10233f@hcegtvedt \
--to=hans-christian.egtvedt@atmel.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=dan.j.williams@intel.com \
--cc=hskinnemoen@atmel.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®