From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758443AbZBBUyv (ORCPT ); Mon, 2 Feb 2009 15:54:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752890AbZBBUym (ORCPT ); Mon, 2 Feb 2009 15:54:42 -0500 Received: from e28smtp05.in.ibm.com ([59.145.155.5]:35254 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753011AbZBBUyl (ORCPT ); Mon, 2 Feb 2009 15:54:41 -0500 Date: Tue, 3 Feb 2009 02:24:34 +0530 From: Balbir Singh To: David Rientjes Cc: KOSAKI Motohiro , KAMEZAWA Hiroyuki , Andrew Morton , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" , "lizf@cn.fujitsu.com" , "linux-mm@kvack.org" Subject: Re: [-mm patch] Show memcg information during OOM Message-ID: <20090202205434.GI918@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20090202125240.GA918@balbir.in.ibm.com> <20090202215527.EC92.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20090202141705.GE918@balbir.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * David Rientjes [2009-02-02 12:37:54]: > On Mon, 2 Feb 2009, Balbir Singh wrote: > > > I think you'd want a less critical log level for these messages such as > KERN_INFO. David, I'd agree, but since we are under printk_ratelimit() and this is a not-so-common path, does the log level matter much? If it does, I don't mind using KERN_INFO. -- Balbir