From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757286AbZBBM7r (ORCPT ); Mon, 2 Feb 2009 07:59:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753493AbZBBM7i (ORCPT ); Mon, 2 Feb 2009 07:59:38 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:60214 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753223AbZBBM7h (ORCPT ); Mon, 2 Feb 2009 07:59:37 -0500 From: KOSAKI Motohiro To: balbir@linux.vnet.ibm.com Subject: Re: [-mm patch] Show memcg information during OOM Cc: kosaki.motohiro@jp.fujitsu.com, KAMEZAWA Hiroyuki , Andrew Morton , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" , "lizf@cn.fujitsu.com" , "linux-mm@kvack.org" In-Reply-To: <20090202125240.GA918@balbir.in.ibm.com> References: <20090202125240.GA918@balbir.in.ibm.com> Message-Id: <20090202215527.EC92.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Date: Mon, 2 Feb 2009 21:59:34 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > +void mem_cgroup_print_mem_info(struct mem_cgroup *memcg) > +{ > + printk(KERN_WARNING "Memory cgroups's name %s\n", > + memcg->css.cgroup->dentry->d_name.name); > + printk(KERN_WARNING "Memory cgroup RSS : usage %llu, limit %llu" > + " failcnt %llu\n", res_counter_read_u64(&memcg->res, RES_USAGE), > + res_counter_read_u64(&memcg->res, RES_LIMIT), > + res_counter_read_u64(&memcg->res, RES_FAILCNT)); > + printk(KERN_WARNING "Memory cgroup swap: usage %llu, limit %llu " > + "failcnt %llu\n", res_counter_read_u64(&memcg->res, RES_USAGE), > + res_counter_read_u64(&memcg->res, RES_LIMIT), > + res_counter_read_u64(&memcg->res, RES_FAILCNT)); s/res/memsw/ ? and, I don't like the name of "Memory cgroup RSS" and "Memory cgroup swap". it seems misleading. memcg->res doesn't only count count rss, but also cache. memcg->memsw doesn't only count swap, but also memory. otherthing, I think it is good patch for me :) > +} > + > /* > * Unlike exported interface, "oom" parameter is added. if oom==true, > * oom-killer can be invoked. > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index d3b9bac..b8e53ae 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -392,6 +392,7 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order, > current->comm, gfp_mask, order, current->oomkilladj); > task_lock(current); > cpuset_print_task_mems_allowed(current); > + mem_cgroup_print_mem_info(mem); > task_unlock(current); > dump_stack(); > show_mem(); > > -- > Balbir > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org