Re: [PATCH] Fix sata_sil compilation error with libata debug enabled (2.6.29-rcX)

["Pasi Kärkkäinen" <pasik@iki.fi>]

On Mon, Feb 02, 2009 at 10:38:43PM -0500, Jeff Garzik wrote:
> Pasi Kärkkäinen wrote:
> >Hello!
> >
> >I tried compiling 2.6.29-rc1 and 2.6.29-rc3 with libata debugging enabled
> >and got the following error:
> >
> >  CC [M]  drivers/ata/sata_sil.o
> >drivers/ata/sata_sil.c: In function 'sil_fill_sg':
> >drivers/ata/sata_sil.c:327: error: 'pi' undeclared (first use in this 
> >function)
> >drivers/ata/sata_sil.c:327: error: (Each undeclared identifier is reported 
> >only once
> >drivers/ata/sata_sil.c:327: error: for each function it appears in.)
> >make[2]: *** [drivers/ata/sata_sil.o] Error 1
> >make[1]: *** [drivers/ata] Error 2
> >make: *** [drivers] Error 2
> >
> >include/linux/libata.h has the following enabled:
> >
> >#define ATA_DEBUG
> >#define ATA_VERBOSE_DEBUG
> >#define ATA_IRQ_TRAP
> >
> >The attached patch fixes the compilation.. I'm not sure if it's the correct
> >fix, but looking at the code it seems correct.. or at least makes the
> >code compile for me :)
> 
> applied
> 

Great, thanks!

-- Pasi