From: Ingo Molnar <mingo@elte.hu>
To: Mandeep Singh Baines <msb@google.com>
Cc: "Frédéric Weisbecker" <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, rientjes@google.com,
mbligh@google.com, thockin@google.com,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2 v2] softlockup: check all tasks in hung_task
Date: Tue, 3 Feb 2009 13:23:46 +0100 [thread overview]
Message-ID: <20090203122346.GE19979@elte.hu> (raw)
In-Reply-To: <20090203000505.GA10316@google.com>
* Mandeep Singh Baines <msb@google.com> wrote:
> + if (sysctl_hung_task_check_count && !(max_count--)) {
> + max_count = sysctl_hung_task_check_count;
just a minor nit, why not:
!--max_count
?
That way we can lose the parenthesis and we'll also not overcount and wont
let max_count go down to -1.
Ingo
next prev parent reply other threads:[~2009-02-03 12:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 20:50 [RFC][PATCH 2/2] add a counter for writers spinning on a rwlock Frederic Weisbecker
2009-01-26 13:32 ` Ingo Molnar
2009-01-26 13:48 ` Peter Zijlstra
2009-01-26 15:25 ` Frédéric Weisbecker
2009-01-26 15:37 ` Peter Zijlstra
2009-01-26 16:04 ` Frédéric Weisbecker
2009-01-26 17:36 ` Mandeep Baines
2009-01-26 17:41 ` Peter Zijlstra
2009-01-27 0:30 ` [PATCH v4] softlockup: remove hung_task_check_count Mandeep Singh Baines
2009-01-27 9:27 ` Frederic Weisbecker
2009-01-27 13:26 ` Ingo Molnar
2009-01-27 18:48 ` Mandeep Singh Baines
2009-01-28 8:25 ` Peter Zijlstra
2009-01-29 1:42 ` Mandeep Singh Baines
2009-01-30 20:41 ` Mandeep Singh Baines
2009-01-30 20:46 ` [PATCH 1/2] softlockup: convert read_lock in hung_task to rcu_read_lock Mandeep Singh Baines
2009-01-30 20:49 ` [PATCH 2/2] softlockup: check all tasks in hung_task Mandeep Singh Baines
2009-01-31 19:22 ` Peter Zijlstra
2009-02-03 0:05 ` [PATCH 2/2 v2] " Mandeep Singh Baines
2009-02-03 12:23 ` Ingo Molnar [this message]
2009-02-03 20:56 ` [PATCH 2/2 v3] " Mandeep Singh Baines
2009-02-04 19:43 ` Ingo Molnar
2009-02-05 4:35 ` [PATCH 2/2 v4] " Mandeep Singh Baines
2009-02-05 14:34 ` Ingo Molnar
2009-02-05 17:48 ` Andrew Morton
2009-02-05 18:07 ` Ingo Molnar
2009-02-05 18:30 ` Andrew Morton
2009-02-05 18:58 ` Ingo Molnar
2009-02-05 18:40 ` Mandeep Singh Baines
2009-02-05 17:56 ` [PATCH] softlockup: convert read_lock in hung_task to rcu_read_lock Mandeep Singh Baines
2009-02-05 18:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203122346.GE19979@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=msb@google.com \
--cc=rientjes@google.com \
--cc=thockin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome