From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755887AbZBCPwf (ORCPT ); Tue, 3 Feb 2009 10:52:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755352AbZBCPwV (ORCPT ); Tue, 3 Feb 2009 10:52:21 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:38163 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755781AbZBCPwU (ORCPT ); Tue, 3 Feb 2009 10:52:20 -0500 Date: Tue, 3 Feb 2009 15:52:08 +0000 From: Russell King - ARM Linux To: Paul Walmsley Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Tony Lindgren Subject: Re: [PATCH B 02/10] OMAP2/3 clockdomains: combine pwrdm, pwrdm_name into union in struct clockdomain Message-ID: <20090203155208.GB9840@n2100.arm.linux.org.uk> References: <20090128024301.27240.39391.stgit@localhost.localdomain> <20090128024408.27240.32198.stgit@localhost.localdomain> <20090131120112.GG1394@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 03, 2009 at 02:20:44AM -0700, Paul Walmsley wrote: > Hello Russell, > > On Sat, 31 Jan 2009, Russell King - ARM Linux wrote: > > > On Tue, Jan 27, 2009 at 07:44:11PM -0700, Paul Walmsley wrote: > > > struct clockdomain contains a struct powerdomain *pwrdm and const char > > > *pwrdm_name. The pwrdm_name is only used at initialization to look up > > > the appropriate pwrdm pointer. Combining these into a union saves > > > about 100 bytes on 3430SDP. This patch should not cause any change in > > > kernel function. > > > > For the same reasons as B1, this would seem to be unsafe. > > Fixed; updated patch attached below. Better. Can I have it in email format so git-am can handle it please?