mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, akpm <akpm@linux-foundation.org>,
	jejb <James.Bottomley@steeleye.com>,
	scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH mm/next] libfc: uses/select CRC32
Date: Tue, 3 Feb 2009 19:21:10 +0100	[thread overview]
Message-ID: <20090203182110.GA24821@elte.hu> (raw)
In-Reply-To: <4962A04F.5020404@oracle.com>


* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> libfc uses crc32 functions, so cause it to be built
> via select:
> 
> drivers/built-in.o: In function `fc_frame_crc_check':
> (.text+0x75dae): undefined reference to `crc32_le'
> drivers/built-in.o: In function `fc_fcp_recv':
> fc_fcp.c:(.text+0x7b919): undefined reference to `crc32_le'
> fc_fcp.c:(.text+0x7b9d5): undefined reference to `crc32_le'
> fc_fcp.c:(.text+0x7ba54): undefined reference to `crc32_le'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Hm, is there a reason why this fix has not gone upstream? I'm still 
stumbling across it in build tests with a latest -git base.

	Ingo

      reply	other threads:[~2009-02-03 18:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200901052050.n05Kox9j012519@imap1.linux-foundation.org>
2009-01-05 22:09 ` mmotm 2009-01-05-12-50 uploaded (ubifs) Randy Dunlap
2009-01-05 22:24   ` Andrew Morton
2009-01-06 12:11     ` Artem Bityutskiy
2009-01-06 17:13       ` Andrew Morton
2009-01-05 22:30 ` mmotm 2009-01-05-12-50 uploaded Jiri Slaby
2009-01-06  1:50   ` Jiri Kosina
2009-01-06 11:26     ` Jiri Slaby
2009-01-06  0:05 ` [PATCH mm/next] libfc: uses/select CRC32 Randy Dunlap
2009-02-03 18:21   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090203182110.GA24821@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@steeleye.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®