From: Oliver Neukum <oliver@neukum.org>
To: Greg KH <greg@kroah.com>
Cc: Dave Young <hidave.darkstar@gmail.com>,
wgreathouse@smva.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb-serial : fix the nousb oops
Date: Wed, 4 Feb 2009 09:12:39 +0100 [thread overview]
Message-ID: <200902040912.40521.oliver@neukum.org> (raw)
In-Reply-To: <20090203235814.GA22380@kroah.com>
Am Wednesday 04 February 2009 00:58:14 schrieb Greg KH:
> On Mon, Feb 02, 2009 at 09:43:04AM +0800, Dave Young wrote:
> > No, it is not new thing. usb serial drivers normally call
> > usb_serial_register first, then usb_register, usb_register will fail
> > due to "nousb" checking, but usb_serial_register no.
>
> But as usb_register will fail, shouldn't they properly back out and no
> oopses happen? This sounds like a simple fix to the drivers that are
> failing here, not changing the usb-serial core.
usb_register() can also fail for other reasons. There's no way you
can save drivers from needing to cleanly fail in that case.
> And this should only be an issue if you build your drivers into the
> kernel, right?
No, you can load drivers by other methods than udev.
Regards
Oliver
prev parent reply other threads:[~2009-02-04 8:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 10:53 Dave Young
2009-02-01 15:51 ` Greg KH
2009-02-02 1:43 ` Dave Young
2009-02-02 10:11 ` Dave Young
2009-02-03 23:58 ` Greg KH
2009-02-04 1:10 ` Dave Young
2009-02-04 23:59 ` Greg KH
2009-02-05 9:33 ` Dave Young
2009-02-06 2:16 ` Dave Young
2009-02-04 8:12 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902040912.40521.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=greg@kroah.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wgreathouse@smva.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®