mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Dean Nelson <dcn@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sgi-xp: fix writing past the end of kzalloc()'d space (v.2)
Date: Wed, 4 Feb 2009 11:57:21 -0800	[thread overview]
Message-ID: <20090204115721.74531d5c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090204183641.GA24632@sgi.com>

On Wed, 4 Feb 2009 12:36:41 -0600 Dean Nelson <dcn@sgi.com> wrote:

> Note that I'm using 'void *' instead of 'u8 *' to ->define recv_msg_slots.
> Currently they are equivalent in terms of the math, but 'void *' has the
> advantage of not needing to cast at all. Is this an appropriate choice?

I think so.  void* is a nice way of saying "here's a blob of bytes". 
It's a gcc extension to permit arithmetic on a void*, but we use that
one widely.


      reply	other threads:[~2009-02-04 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 18:23 [PATCH] sgi-xp: add type cast to kzalloc()'d space to avoid slab corruption Dean Nelson
2009-02-03 20:01 ` Andrew Morton
2009-02-04 18:36   ` [PATCH] sgi-xp: fix writing past the end of kzalloc()'d space (v.2) Dean Nelson
2009-02-04 19:57     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090204115721.74531d5c.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dcn@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome