mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] reparent_thread: fix the "is it traced" check
Date: Wed,  4 Feb 2009 18:16:18 -0800 (PST)	[thread overview]
Message-ID: <20090205021618.8738FFC381@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Thursday, 29 January 2009 09:05:58 +0100 <20090129080558.GA26871@redhat.com>

> reparent_thread() uses ptrace_reparented() to check whether this thread
> is ptraced, in that case we should not notify the new parent.

I think at some point in the past, ptracedness could sometimes transfer to
the new parent, so this made sense then (before it had that name).

> But ptrace_reparented() is not exactly correct when the reparented thread
> is traced by /sbin/init, because forget_original_parent() has already
> changed ->real_parent.

Heh.  Ok.  I think the !p->ptrace check is fine.

Acked-by: Roland McGrath <roland@redhat.com>


Thanks,
Roland

      reply	other threads:[~2009-02-05  2:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29  8:05 Oleg Nesterov
2009-02-05  2:16 ` Roland McGrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090205021618.8738FFC381@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®