mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>, Lin Ming <ming.m.lin@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] posix-cpu-timers: use ->sighand instead of ->signal to check the task is alive
Date: Wed,  4 Feb 2009 19:31:20 -0800 (PST)	[thread overview]
Message-ID: <20090205033120.2294BFC381@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Wednesday, 4 February 2009 00:17:17 +0100 <20090203231717.GA5028@redhat.com>

> It doesn't matter which pointer to check under tasklist to ensure the task
> was not released, ->signal or ->sighand. But we are going to make ->signal
> refcountable, change the code to use ->sighand.

I haven't been following what that's about (signal_struct already has two
atomic counts!).  Uses here protecting cpu_clock_sample_group() e.g., are
around looking at ->signal->foobar, so if ->signal is still there, why not
look at it and be able to get the sample in whatever small window this is?

I don't really understand what this new case might mean though.  Most
things that look at ->signal need to lock it, so access doesn't make any
sense if there is no siglock because ->sighand is clear while ->signal is not.


Thanks,
Roland

  parent reply	other threads:[~2009-02-05  3:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 23:17 Oleg Nesterov
2009-02-04 11:21 ` Peter Zijlstra
2009-02-04 13:19   ` Oleg Nesterov
2009-02-05  3:31 ` Roland McGrath [this message]
2009-02-05 15:54   ` Oleg Nesterov
2009-02-05 20:45     ` Roland McGrath
2009-02-05 22:59       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090205033120.2294BFC381@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®