From: Ingo Molnar <mingo@elte.hu>
To: "Gustavo F. Padovan" <gustavo@las.ic.unicamp.br>
Cc: linux-kernel@vger.kernel.org, glommer@redhat.com,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 6/6] x86: unify fixmap.h
Date: Fri, 6 Feb 2009 00:45:29 +0100 [thread overview]
Message-ID: <20090205234529.GC14203@elte.hu> (raw)
In-Reply-To: <1233873586-7149-7-git-send-email-gustavo@las.ic.unicamp.br>
* Gustavo F. Padovan <gustavo@las.ic.unicamp.br> wrote:
> This patch unify fixmap_32.h and fixmap_64.h into fixmap.h.
> Things that we can't merge now are using CONFIG_X86_{32,64}
> (e.g.:vsyscall and EFI)
>
> Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
> Acked-by: Glauber Costa <gcosta@redhat.com>
> ---
> arch/x86/include/asm/fixmap.h | 153 +++++++++++++++++++++++++++++++++++++-
> arch/x86/include/asm/fixmap_32.h | 119 -----------------------------
> arch/x86/include/asm/fixmap_64.h | 94 -----------------------
> 3 files changed, 151 insertions(+), 215 deletions(-)
> delete mode 100644 arch/x86/include/asm/fixmap_32.h
> delete mode 100644 arch/x86/include/asm/fixmap_64.h
Please split this patch up into 3 parts:
#1: "x86: prepare fixmap_32.h for unification"
#2: "x86: prepare fixmap_64.h for unification"
#3: "x86: mechanic unification of fixmap_32/64.h => fixmap.h"
ok?
That way it's reviewable what happened during the unification,
with the above patch it isnt.
Ingo
next prev parent reply other threads:[~2009-02-05 23:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 22:39 [PATCH 0/6] x86: fixmap.h x86 integration Gustavo F. Padovan
2009-02-05 22:39 ` [PATCH 1/6] x86: rename __FIXADDR_SIZE and __FIXADDR_BOOT_SIZE Gustavo F. Padovan
2009-02-05 22:39 ` [PATCH 2/6] x86: define FIXADDR_BOOT_* and redefine FIX_ADDR_SIZE Gustavo F. Padovan
2009-02-05 22:39 ` [PATCH 3/6] x86: define reserve_top_address for x86_64 Gustavo F. Padovan
2009-02-05 22:39 ` [PATCH 4/6] x86: Add CONFIG_X86_{LOCAL,IO}_APIC Gustavo F. Padovan
2009-02-05 22:39 ` [PATCH 5/6] x86: Add CONFIG_EFI Gustavo F. Padovan
2009-02-05 22:39 ` [PATCH 6/6] x86: unify fixmap.h Gustavo F. Padovan
2009-02-05 23:45 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-02 2:23 [PATCH 0/6] " Gustavo F. Padovan
2008-11-02 2:23 ` [PATCH 1/6] x86: rename __FIXADDR_SIZE and __FIXADDR_BOOT_SIZE Gustavo F. Padovan
2008-11-02 2:23 ` [PATCH 2/6] x86: define FIXADDR_BOOT_* and redefine FIX_ADDR_SIZE Gustavo F. Padovan
2008-11-02 2:23 ` [PATCH 3/6] x86: define reserve_top_address for x86_64 Gustavo F. Padovan
2008-11-02 2:23 ` [PATCH 4/6] x86: Add CONFIG_X86_{LOCAL,IO}_APIC Gustavo F. Padovan
2008-11-02 2:23 ` [PATCH 5/6] x86: Add CONFIG_EFI Gustavo F. Padovan
2008-11-02 2:23 ` [PATCH 6/6] x86: Unify fixmap.h Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205234529.GC14203@elte.hu \
--to=mingo@elte.hu \
--cc=glommer@redhat.com \
--cc=gustavo@las.ic.unicamp.br \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®