From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758833AbZBFClk (ORCPT ); Thu, 5 Feb 2009 21:41:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752089AbZBFCl1 (ORCPT ); Thu, 5 Feb 2009 21:41:27 -0500 Received: from fg-out-1718.google.com ([72.14.220.159]:12515 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758711AbZBFClZ (ORCPT ); Thu, 5 Feb 2009 21:41:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=TZcd+QhLujKWJXWX47c2sMfZj/Let03CO/+5NMr3ydsRQYDlJyGngeMzU91/H+WAP6 r4H2Ylhr0MCs0vSmrYhBAIKnHeDU/In4hHdbaKnTfkdWui3VjjsztswlVVaZXmpEl92M 0rh+rl4oTS8BM1y0SbA5ADBquG8evAom3wUXo= Date: Fri, 6 Feb 2009 03:41:21 +0100 From: Frederic Weisbecker To: Arnaldo Carvalho de Melo Cc: Steven Rostedt , Ingo Molnar , Jens Axboe , Linux Kernel Mailing List Subject: Re: [PATCH tip 1/2] ring_buffer: remove unused flags parameter Message-ID: <20090206024121.GB24546@nowhere> References: <20090205181256.GH17653@ghostprotocols.net> <20090205221701.GA23999@nowhere> <20090206014840.GE9846@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090206014840.GE9846@ghostprotocols.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 05, 2009 at 11:48:40PM -0200, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 05, 2009 at 11:17:02PM +0100, Frederic Weisbecker escreveu: > > On Thu, Feb 05, 2009 at 04:12:56PM -0200, Arnaldo Carvalho de Melo wrote: > > > Impact: API change, cleanup > > > > > > From ring_buffer_{lock_reserve,unlock_commit}. > > > > > > Cc: Ingo Molnar > > > Cc: Frédéric Weisbecker > > > Cc: Jens Axboe > > > Signed-off-by: Arnaldo Carvalho de Melo > > > --- > > > block/blktrace.c | 8 +++--- > > > include/linux/ring_buffer.h | 9 ++---- > > > kernel/trace/kmemtrace.c | 12 +++----- > > > kernel/trace/ring_buffer.c | 9 +----- > > > kernel/trace/trace.c | 56 +++++++++++++------------------------ > > > kernel/trace/trace_boot.c | 12 +++----- > > > kernel/trace/trace_branch.c | 7 ++--- > > > kernel/trace/trace_hw_branches.c | 6 ++-- > > > kernel/trace/trace_mmiotrace.c | 12 +++----- > > > kernel/trace/trace_power.c | 12 +++----- > > > 10 files changed, 51 insertions(+), 92 deletions(-) > > > > > > $ codiff /tmp/vmlinux.before /tmp/vmlinux.after > > > linux-2.6-tip/kernel/trace/trace.c: > > > trace_vprintk | -14 > > > trace_graph_return | -14 > > > trace_graph_entry | -10 > > > trace_function | -8 > > > __ftrace_trace_stack | -8 > > > ftrace_trace_userstack | -8 > > > tracing_sched_switch_trace | -8 > > > ftrace_trace_special | -12 > > > tracing_sched_wakeup_trace | -8 > > > 9 functions changed, 90 bytes removed, diff: -90 > > > > > > linux-2.6-tip/block/blktrace.c: > > > __blk_add_trace | -1 > > > 1 function changed, 1 bytes removed, diff: -1 > > > > > > /tmp/vmlinux.after: > > > 10 functions changed, 91 bytes removed, diff: -91 > > > > > > codiff... I didn't know this great tool! :-) > > My marketing dept is not so good, but since you liked it, I guess its > appropriate to point you to this, that is the only documentation > available about it and some of its friends, like pahole: > > https://ols2006.108.redhat.com/2007/Reprints/melo-Reprint.pdf Oh thank you! :-) > Now back to the Rostedts extended TODO list. > > - Arnaldo