From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bryan Wu <cooloney@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Sonic Zhang <sonic.zhang@analog.com>,
Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH] tty: fix bug - kernel can't be pinged through when bootargs console=null
Date: Fri, 6 Feb 2009 10:06:07 +0000 [thread overview]
Message-ID: <20090206100607.277d83e2@the-village.bc.nu> (raw)
In-Reply-To: <1233908877-7729-1-git-send-email-cooloney@kernel.org>
On Fri, 6 Feb 2009 16:27:57 +0800
Bryan Wu <cooloney@kernel.org> wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> when pass bootargs console=null into kernel from u-boot, the booted up
> kernel can't be pinged through. This happens after the kernel is upgraded
> to 2.6.28.
>
> Should check if tty_driver is NULL before call kref_get() in tty_driver_kref_get().
Should not call tty_driver_kref_get(NULL) in the first place....
Need to fix the real bug not paper over it
next prev parent reply other threads:[~2009-02-06 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 8:27 Bryan Wu
2009-02-06 10:06 ` Alan Cox [this message]
2009-02-07 0:05 ` Andrew Morton
2009-02-07 0:09 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206100607.277d83e2@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®