From: Samuel Ortiz <sameo@openedhand.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd/htc-egpio: fix iomem resource handling using resource_size
Date: Fri, 6 Feb 2009 15:03:11 +0100 [thread overview]
Message-ID: <20090206140310.GG3341@sortiz.org> (raw)
In-Reply-To: <1233434863-11806-1-git-send-email-philipp.zabel@gmail.com>
On Sat, Jan 31, 2009 at 09:47:43PM +0100, Philipp Zabel wrote:
> Fixes an off-by-one error in the iomem resource mapping.
Applied to my for-linus branch. Will Send a pull request to Linus soon.
Thanks a lot.
Cheers,
Samuel.
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
> ---
> drivers/mfd/htc-egpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/htc-egpio.c b/drivers/mfd/htc-egpio.c
> index 1a4d046..e9b0745 100644
> --- a/drivers/mfd/htc-egpio.c
> +++ b/drivers/mfd/htc-egpio.c
> @@ -286,7 +286,7 @@ static int __init egpio_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res)
> goto fail;
> - ei->base_addr = ioremap_nocache(res->start, res->end - res->start);
> + ei->base_addr = ioremap_nocache(res->start, resource_size(res));
> if (!ei->base_addr)
> goto fail;
> pr_debug("EGPIO phys=%08x virt=%p\n", (u32)res->start, ei->base_addr);
> --
> 1.5.6.5
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2009-02-06 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 20:47 Philipp Zabel
2009-02-06 14:03 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206140310.GG3341@sortiz.org \
--to=sameo@openedhand.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®