mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: H Peter Anvin <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	thomas@linux-os.sc.intel.com,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Add clflush before monitor for Intel 7400 series - v2
Date: Sat, 7 Feb 2009 14:02:45 +0000	[thread overview]
Message-ID: <20090207140245.1e91a88f@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090207004728.GA17586@linux-os.sc.intel.com>

On Fri, 6 Feb 2009 16:47:29 -0800
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com> wrote:

> 
> 
> For Intel 7400 series CPUs, the recommendation is to use a clflush on the
> monitored address just before monitor and mwait pair [1]. This clflush makes
> sure that there are no false wakeups from mwait when the monitored address
> was recently written to.

Given our mwait usages will very quickly go back to sleep in such a case
and it would almost certainly be one sleep only is this really worth the
effort ?

  reply	other threads:[~2009-02-07 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-07  0:47 Pallipadi, Venkatesh
2009-02-07 14:02 ` Alan Cox [this message]
2009-02-07 16:47   ` Pallipadi, Venkatesh
2009-02-09  5:53     ` Nick Piggin
2009-02-09 21:37       ` Pallipadi, Venkatesh
2009-02-07  0:52 Pallipadi, Venkatesh
2009-02-09 10:15 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090207140245.1e91a88f@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=thomas@linux-os.sc.intel.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®