mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux PCI <linux-pci@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] PCI PM: Do not disable and enable bridges during suspend-resume
Date: Mon, 9 Feb 2009 10:39:26 +0100	[thread overview]
Message-ID: <20090209093926.GA4358@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <200902081423.08991.rjw@sisk.pl>

> On Sunday 08 February 2009, Pavel Machek wrote:
> > Hi!
> > 
> > > > > their standard config spaces are restored.  Fix this by not attempting
> > > > > to disable bridges during suspend and enable them during resume.
> > > > ...
> > > > > @@ -428,16 +428,18 @@ static int pci_pm_default_resume(struct 
> > > > >  {
> > > > >  	pci_fixup_device(pci_fixup_resume, pci_dev);
> > > > >  
> > > > > -	if (!pci_is_bridge(pci_dev))
> > > > > -		pci_enable_wake(pci_dev, PCI_D0, false);
> > > > > +	if (pci_is_bridge(pci_dev))
> > > > > +		return 0;
> > > > >  
> > > > > +	pci_enable_wake(pci_dev, PCI_D0, false);
> > > > >  	return pci_pm_reenable_device(pci_dev);
> > > > >  }
> > > > 
> > > > Are you sure? This goes from doing reenable_device to not doing it for
> > > > bridges, seemingly contradicting changelog?
> > > 
> > > Can you explain what you mean, please?
> > 
> > It looks to me like the patch does not match the changelog.
> > 
> > Changelog says "enable bridge during resume", but code does return 0
> > if it seems bridge.
> 
> Ah, I see.  The changelog was supposed to mean that the bridges would not
> be disabled during suspend and also would not be enabled during resume
> (which shouldn't be necessary, since they would be automatically enabled
> as a result of restoring their configuration registers).

You can add my acked-by: when you resubmit with fixed
changelog... :-).
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2009-02-09  9:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-01 21:29 [PATCH 0/3] PCI PM: More refinements of suspend-resume framework Rafael J. Wysocki
2009-02-01 21:31 ` [PATCH 1/3] PCI PM: Do not disable and enable bridges during suspend-resume Rafael J. Wysocki
2009-02-07  9:50   ` Pavel Machek
2009-02-07 13:48     ` Rafael J. Wysocki
2009-02-08  9:11       ` Pavel Machek
2009-02-08 13:23         ` Rafael J. Wysocki
2009-02-09  9:39           ` Pavel Machek [this message]
2009-02-10  0:21             ` Rafael J. Wysocki
2009-02-01 21:33 ` [PATCH 2/3] PCI PM: Let the core be more careful with respect to drivers using new framework Rafael J. Wysocki
2009-02-02  2:06   ` [linux-pm] " Nigel Cunningham
2009-02-02 12:04     ` Rafael J. Wysocki
2009-02-02 17:27       ` Rafael J. Wysocki
2009-02-01 21:34 ` [PATCH 3/3] PCI PM: Make warning in pci_legacy_suspend more useful Rafael J. Wysocki
2009-02-02  2:10   ` [linux-pm] " Nigel Cunningham
2009-02-02 12:02     ` Rafael J. Wysocki
2009-02-02 18:32 ` [PATCH 0/3] PCI PM: More refinements of suspend-resume framework Jesse Barnes
2009-02-03  3:25   ` Linus Torvalds
2009-02-03  8:26     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090209093926.GA4358@atrey.karlin.mff.cuni.cz \
    --to=pavel@suse.cz \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®