From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/function-graph-tracer: handle the leaf functions from trace_pipe
Date: Mon, 9 Feb 2009 12:37:48 +0100 [thread overview]
Message-ID: <20090209113748.GD18757@elte.hu> (raw)
In-Reply-To: <498c7909.11355e0a.5fc7.4ff2@mx.google.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> When one cat on the trace file, the leaf functions are printed without brackets:
>
> function();
>
> whereas in the trace_pipe file we'll see the following:
>
> function() {
> }
>
> This is because the ring_buffer handling is not the same between those two files.
> On the trace file, when an entry is printed, the iterator advanced and then we can
> check the next entry.
>
> There is no iterator with trace_pipe, the current entry to print has been peeked
> and not consumed. So checking the next entry will still return the current one while
> we don't consume it.
>
> This patch introduces a new value for the output callbacks to ask the tracing
> core to not consume the current entry after printing it.
> We need it because we will have to consume the current entry ourself to check the next one.
>
> Now the trace_pipe is able to handle well the leaf functions.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> kernel/trace/trace.c | 4 +-
> kernel/trace/trace.h | 7 +++--
> kernel/trace/trace_functions_graph.c | 48 +++++++++++++++++++++------------
> 3 files changed, 36 insertions(+), 23 deletions(-)
Applied to tip/tracing/ftrace, thanks Frederic!
Ingo
prev parent reply other threads:[~2009-02-09 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 17:30 Frederic Weisbecker
2009-02-06 18:01 ` Steven Rostedt
2009-02-09 11:37 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209113748.GD18757@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®