From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756766AbZBIOSG (ORCPT ); Mon, 9 Feb 2009 09:18:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757254AbZBIORQ (ORCPT ); Mon, 9 Feb 2009 09:17:16 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:52593 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756384AbZBIORP (ORCPT ); Mon, 9 Feb 2009 09:17:15 -0500 Date: Mon, 9 Feb 2009 15:17:08 +0100 From: Ingo Molnar To: Steven Rostedt Cc: Eduard - Gabriel Munteanu , fweisbec@gmail.com, penberg@cs.helsinki.fi, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/2] splice patches for ftrace Message-ID: <20090209141708.GA27131@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > > On Mon, 9 Feb 2009, Eduard - Gabriel Munteanu wrote: > > > Hi, > > > > This implements splice support so we can use it in kmemtrace-user. Please > > check it out and tell me what you think. > > > > The "RFC" in the subject reads like "I tested this the best I could, > > although kmemtrace-user isn't still ready.". As we speak, I'm working on > > making kmemtrace over ftrace and kmemtrace-user work together nicely. > > Hi Eduard! > > Thanks, I'll give it a test. I've been playing on my spare time with > a ring buffer splice interface. But I've not had the time to get it > working fully. My version would be a binary only interface, but I really > like the text interface you have. > > You can look at my old changes at: > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git > > The branch tip/splice-broken > > As the name suggests, it is still broken ;-) I'd suggest we pick up Eduard's, with the fixes i suggested - because they clearly work for his kmemtrace utility! Then pick up whatever is left in your branch. Ingo