From: Andrew Morton <akpm@linux-foundation.org>
To: "hartleys" <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org, miguel.ojeda.sandonis@gmail.com
Subject: Re: [PATCH] auxdisplay: remove PARPORT dependency
Date: Mon, 9 Feb 2009 14:37:16 -0800 [thread overview]
Message-ID: <20090209143716.57467016.akpm@linux-foundation.org> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090120BD69@mi8nycmail19.Mi8.com>
(please cc the maintainers on patches)
On Fri, 6 Feb 2009 19:06:51 -0500
"hartleys" <hartleys@visionengravers.com> wrote:
> Remove PARPORT dependency for Auxiliary Display support.
>
> This is not needed since the dependency for the KS0108 driver is
> PARPORT_PC.
>
OK, but the patch also accidentally removes the parport dependency from
cfag12864b.c and cfag12864bfb.c.
A quick grep indicates that those drivers don't need parport, but I
didn't look very closely.
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 14b9d5f..c07e725 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -6,7 +6,6 @@
> #
>
> menuconfig AUXDISPLAY
> - depends on PARPORT
> bool "Auxiliary Display support"
> ---help---
> Say Y here to get to see options for auxiliary display
> drivers.
> @@ -14,7 +13,7 @@ menuconfig AUXDISPLAY
>
> If you say N, all options in this submenu will be skipped and
> disabled.
>
> -if AUXDISPLAY && PARPORT
> +if AUXDISPLAY
>
> config KS0108
> tristate "KS0108 LCD Controller"
Your email client wordwraps patches. Please fix that up for next time.
next prev parent reply other threads:[~2009-02-09 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 0:06 hartleys
2009-02-09 22:37 ` Andrew Morton [this message]
2009-02-09 22:46 ` hartleys
2009-02-11 10:37 ` Miguel Ojeda
2009-02-11 16:51 ` hartleys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209143716.57467016.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®