mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lennert Buytenhek <buytenh@wantstofly.org>
To: rusty@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org
Subject: /proc/profile broken on UP machines in 2.6.29-rc3
Date: Mon, 9 Feb 2009 15:50:58 +0100	[thread overview]
Message-ID: <20090209145058.GY13433@xi.wantstofly.org> (raw)

I'm about 130k emails behind on my linux-kernel@ subscription, so I'm
not entirely sure whether this has been reported, but it seems that
profiling is broken on !CONFIG_SMP builds in 2.6.29-rc3.

It appears that since this commit:

	commit c309b917cab55799ea489d7b5f1b77025d9f8462
	Author: Rusty Russell <rusty@rustcorp.com.au>
	Date:   Thu Jan 1 10:12:27 2009 +1030

	    cpumask: convert kernel/profile.c

there's no longer anything that sets any bits in prof_cpu_mask on
UP systems at all (the default was to assign CPU_MASK_ALL, and
profile_cpu_callback() which clears/sets bits at run time is only
built and registered on SMP builds), so the cpumask_test_cpu()
test in profile_tick() always fails, and no samples are ever counted.

             reply	other threads:[~2009-02-09 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09 14:50 Lennert Buytenhek [this message]
2009-02-09 19:20 ` Hugh Dickins
2009-02-09 23:50   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090209145058.GY13433@xi.wantstofly.org \
    --to=buytenh@wantstofly.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®