From: Alexey Dobriyan <adobriyan@gmail.com>
To: Mike Travis <travis@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: include/linux/irq.h:452: error: implicit declaration of function 'cpu_to_node'
Date: Mon, 9 Feb 2009 23:35:02 +0300 [thread overview]
Message-ID: <20090209203502.GA7701@x200.localdomain> (raw)
In-Reply-To: <4977B1F1.1090602@sgi.com>
On Wed, Jan 21, 2009 at 03:38:25PM -0800, Mike Travis wrote:
> Alexey Dobriyan wrote:
> > On mips-malta:
> >
> > CC arch/mips/mti-malta/malta-int.o
> > In file included from arch/mips/mti-malta/malta-int.c:25:
> > include/linux/irq.h: In function 'init_alloc_desc_masks':
> > include/linux/irq.h:452: error: implicit declaration of function 'cpu_to_node'
> > include/linux/irq.h:454: error: 'GFP_ATOMIC' undeclared (first use in this function)
> >
> > I _think_ init_alloc_desc_masks() should be made out of line to fix this.
>
> Hi Alexey,
>
> Does adding #include <linux/slab.h> fix the error? If so, I can add this to
> linux/irq.h.
>
> The primary reason it's inline is that unless CONFIG_CPUMASK_OFFSTACK=y, then the
> entire routine is a NOP which optimizes out more completely as an inline function.
linux/slab.h helps.
next prev parent reply other threads:[~2009-02-09 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 21:53 Alexey Dobriyan
2009-01-21 23:38 ` Mike Travis
2009-02-09 20:35 ` Alexey Dobriyan [this message]
2009-02-09 22:05 ` Mike Travis
2009-02-09 22:08 ` Mike Travis
2009-02-09 22:29 ` Alexey Dobriyan
2009-02-09 22:32 ` Mike Travis
2009-02-09 22:40 ` Alexey Dobriyan
2009-02-09 23:06 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209203502.GA7701@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®