From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754900AbZBJLrd (ORCPT ); Tue, 10 Feb 2009 06:47:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753434AbZBJLrX (ORCPT ); Tue, 10 Feb 2009 06:47:23 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:35614 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753634AbZBJLrX (ORCPT ); Tue, 10 Feb 2009 06:47:23 -0500 From: KOSAKI Motohiro To: balbir@linux.vnet.ibm.com Subject: [PATCH] memcg: remove mem_cgroup_calc_mapped_ratio() take2 Cc: kosaki.motohiro@jp.fujitsu.com, KAMEZAWA Hiroyuki , LKML , linux-mm , Andrew Morton , Johannes Weiner In-Reply-To: <20090210105931.GD16317@balbir.in.ibm.com> References: <20090210184249.6FCD.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20090210105931.GD16317@balbir.in.ibm.com> Message-Id: <20090210204539.6FF5.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Date: Tue, 10 Feb 2009 20:47:20 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changelog: v1 -> v2 - The calc_mapped_ratio prototype also be removed. ======== Currently, mem_cgroup_calc_mapped_ratio() is unused at all. it can be removed and KAMEZAWA-san suggested it. Signed-off-by: KOSAKI Motohiro Cc: KAMEZAWA Hiroyuki Acked-by: Balbir Singh Cc: Johannes Weiner --- include/linux/memcontrol.h | 6 ------ mm/memcontrol.c | 17 ----------------- 2 files changed, 23 deletions(-) Index: b/mm/memcontrol.c =================================================================== --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -445,23 +445,6 @@ int task_in_mem_cgroup(struct task_struc return ret; } -/* - * Calculate mapped_ratio under memory controller. This will be used in - * vmscan.c for deteremining we have to reclaim mapped pages. - */ -int mem_cgroup_calc_mapped_ratio(struct mem_cgroup *mem) -{ - long total, rss; - - /* - * usage is recorded in bytes. But, here, we assume the number of - * physical pages can be represented by "long" on any arch. - */ - total = (long) (mem->res.usage >> PAGE_SHIFT) + 1L; - rss = (long)mem_cgroup_read_stat(&mem->stat, MEM_CGROUP_STAT_RSS); - return (int)((rss * 100L) / total); -} - static int calc_inactive_ratio(struct mem_cgroup *memcg, unsigned long *present_pages) { unsigned long active; Index: b/include/linux/memcontrol.h =================================================================== --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -88,7 +88,6 @@ extern void mem_cgroup_end_migration(str /* * For memory reclaim. */ -extern int mem_cgroup_calc_mapped_ratio(struct mem_cgroup *mem); extern long mem_cgroup_reclaim_imbalance(struct mem_cgroup *mem); int mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg); unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg, @@ -203,11 +202,6 @@ static inline void mem_cgroup_end_migrat { } -static inline int mem_cgroup_calc_mapped_ratio(struct mem_cgroup *mem) -{ - return 0; -} - static inline int mem_cgroup_reclaim_imbalance(struct mem_cgroup *mem) { return 0;