From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757244AbZBKQZx (ORCPT ); Wed, 11 Feb 2009 11:25:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756003AbZBKQZo (ORCPT ); Wed, 11 Feb 2009 11:25:44 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:33462 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754592AbZBKQZo (ORCPT ); Wed, 11 Feb 2009 11:25:44 -0500 Date: Wed, 11 Feb 2009 17:25:30 +0100 From: Ingo Molnar To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Peter Zijlstra , Arnaldo Carvalho de Melo , Frederic Weisbecker Subject: Re: [PATCH 0/8] git pull request for tip/tracing/core Message-ID: <20090211162530.GB32301@elte.hu> References: <20090208054955.777429253@goodmis.org> <20090209093751.GD7930@elte.hu> <20090211153650.GA19576@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > > On Wed, 11 Feb 2009, Ingo Molnar wrote: > > > > > > > Steven Rostedt (7): > > > > ring-buffer: add NMI protection for spinlocks > > > > nmi: add generic nmi tracking state > > > > hm, this commit breaks a number of non-x86 architectures the following way: > > > > In file included from /home/mingo/tip/include/linux/interrupt.h:12, > > from /home/mingo/tip/arch/ia64/include/asm/mca.h:16, > > from /home/mingo/tip/arch/ia64/kernel/asm-offsets.c:17: > > /home/mingo/tip/include/linux/hardirq.h:67:2: #error PREEMPT_ACTIVE too high! > > make[2]: *** [arch/ia64/kernel/asm-offsets.s] Error 1 > > > > Alpha and ARM are broken too. (and possibly others) > > I'm glad we had that check. > > OK, revert it and I'll take a look to see what other options we have. Reverting it is neither simple nor desired: 1) it's now embedded in other tracing commits 2) my test-boxes stopped doing those rare lockups with the NMI fix in place ... Any better approach to fix those platforms? I reported this ftrace NMI problem to you about a year ago ... Ingo