From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: hch@infradead.org, linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [patch] mm: vmap fix overflow
Date: Thu, 12 Feb 2009 03:30:02 +0100 [thread overview]
Message-ID: <20090212023002.GB23790@wotan.suse.de> (raw)
In-Reply-To: <20090211182050.24425324.akpm@linux-foundation.org>
On Wed, Feb 11, 2009 at 06:20:50PM -0800, Andrew Morton wrote:
> On Thu, 12 Feb 2009 02:39:31 +0100 Nick Piggin <npiggin@suse.de> wrote:
> >
> > Oh that's true, good catch. I guess that should be (addr + size - 1)?
> > Because we care about the last byte that was actually allocated to us
> > (inclusive, rather than exclusive).
>
> That would work. It wouldd give weird results for size==0, but probably
> that's already checked for somewhere(?)
It's checked down in __get_vm_area_node.
prev parent reply other threads:[~2009-02-12 2:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 5:51 Nick Piggin
2009-02-10 22:44 ` Andrew Morton
2009-02-12 1:39 ` Nick Piggin
2009-02-12 2:20 ` Andrew Morton
2009-02-12 2:30 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212023002.GB23790@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®