mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	L-K <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] timers: more consistently use clock vs timer
Date: Fri, 13 Feb 2009 13:04:30 +0100	[thread overview]
Message-ID: <20090213120430.GA5483@elte.hu> (raw)
In-Reply-To: <1234448191.10603.9.camel@laptop>


* Peter Zijlstra <peterz@infradead.org> wrote:

> Subject: timers: more consistently use clock vs timer
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Thu Feb 12 15:00:52 CET 2009
> 
> While reviewing the manpages, I noticed I'd missed some clock vs timer sites.
> 
> Make sure that all timer functions call cpu_timer_sample_group() and not
> cpu_clock_sample_group(). This ensures that we enable the process wide timer
> in time, and therefore pay the O(n) thread group cost from the syscall.
> 
> Not doing it here, will result in the first jiffy tick after setting the timer
> doing this, resulting in a very expensive tick (but only once) and a delay in
> actually starting the timer.
> 
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
>  kernel/posix-cpu-timers.c |   60 +++++++++++++++++++++++-----------------------
>  1 file changed, 30 insertions(+), 30 deletions(-)

Applied to tip:timers/urgent, thanks Peter!

	Ingo

      reply	other threads:[~2009-02-13 12:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 14:16 Peter Zijlstra
2009-02-13 12:04 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090213120430.GA5483@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®