mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Greg KH <gregkh@suse.de>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Miles Lane <miles.lane@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	USB list <linux-usb@vger.kernel.org>
Subject: [PATCH 0/1] Fix resume breakage of USB PCI controllers behind cardbus bridges
Date: Fri, 13 Feb 2009 23:40:14 +0100	[thread overview]
Message-ID: <200902132340.15427.rjw@sisk.pl> (raw)

[Sorry for resending, I forgot to send CCs to the mailing lists.]

Hi,

Unfortunately, we broke the resume of USB PCI controllers behind cardbus
bridges by moving the restoration of their standard config registers to
usb_hcd_pci_resume_early().  Namely, if USB PCI controller is behind a cardbus
bridge, we're restoring its config registers too early, before the bridge
becomes operational.

IMO in the future it's better to move the resume of cardbus bridges to the
early resume phase (ie. before device interrupts will be enabled), but for
2.6.29 I think we should just go back to the 2.6.28 behavior, which is to
call pci_restore_state() from usb_hcd_pci_resume().  The following patch
does this.

Thanks,
Rafael


             reply	other threads:[~2009-02-13 22:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 22:40 Rafael J. Wysocki [this message]
2009-02-13 22:41 ` [PATCH 1/1] USB/PCI: Fix resume breakage of " Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902132340.15427.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=gregkh@suse.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®